1004
34%

Ran 03 Aug 2020 01:39AM UTC

Jobs 6

Files 105

Run time 5min

Badge

Embed ▾

pending completion

Build # 1004

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Increase efficiency of accessing members of struct pointers (#250)

The current code to access a member of a struct pointer uses a package function,
`fieldposition`, that has identical functionality to a function provided in
base, `fieldindex`. While this latter function is not exported, it is documented
and will hopefully remain a part of Julia's API. I imagine that the base
function is more performant than the implementation in `fieldposition`, which
compares each field name to the target field name in order to find the position
of a field. As such, I have replaced calls to `fieldposition` with calls to
`Base.fieldindex`, and deleted the function `fieldposition`.

Additionally, when setting a member of a struct pointer, the current
implementation calculates the pointer position, wraps it in a julia array with
`unsafe_wrap`, and then sets the first element of that array to the desired
value. The same result is achieved, perhaps more simply, by using
`unsafe_store!` and not using an intermediate array. I have therefore replaced
the call to `unsafe_wrap` and subsequent code with `unsafe_store!`.

While I do not know if the existing code causes a measurable decrease in
performance, using the base functions reduces the amount of code, and most
likely makes it faster.

Run Details

508 of 1443 relevant lines covered (35.2%)

347695.03 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	1004.1	03 Aug 2020 01:39AM UTC	33.26	Travis Job 1004.1
2	1004.2	03 Aug 2020 01:42AM UTC	34.44	Travis Job 1004.2
3	1004.3	03 Aug 2020 01:40AM UTC	33.96	Travis Job 1004.3
4	1004.4	03 Aug 2020 01:40AM UTC	21.31	Travis Job 1004.4
5	1004.5	03 Aug 2020 01:40AM UTC	22.14	Travis Job 1004.5
6	1004.6	03 Aug 2020 01:44AM UTC	21.75	Travis Job 1004.6

Source Files on build 1004

Detailed source file information is not available for this build.

JuliaIO / VideoIO.jl / 1004
34%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1004

JuliaIO / VideoIO.jl / 1004 34%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1004

JuliaIO / VideoIO.jl / 1004
34%

README BADGES
x