gnosis / dex-services / 4442

31%

push

travis-pro

Retry submitting solution during network congestion (#1216)

Currently we only check for "nonce already used" errors specifically to
determine when we should retry sending a transaction with a higher gas
price and when we should cancel a solution submission transaction.
This commit changes this to include all what openethereum calls
transaction errors. These errors indicate that the transaction did not
execute which can happen for several reasons.
This makes us more flexible with regards to the exact error string. It
has the side effect that we will try to resubmit the transaction with a
higher gas price in cases where this won't help but it also will not
hurt as we will still end up with the same error eventually.
openethereum transaction errors that share this error code (-32010):

```rust
AlreadyImported => "Transaction with the same hash was already imported.".into(),
Old => "Transaction nonce is too low. Try incrementing the nonce.".into(),
TooCheapToReplace { prev, new } => {
        format!("Transaction gas price {} is too low. There is another transaction with same nonce in the queue{}. Try increasing the gas price or incrementing the nonce.",
                        new.map(|gas| format!("{}wei", gas)).unwrap_or("supplied".into()),
                        prev.map(|gas| format!(" with gas price: {}wei", gas)).unwrap_or("".into())
        )
}
LimitReached => {
        "There are too many transactions in the queue. Your transaction was dropped due to limit. Try increasing the fee.".into()
}
InsufficientGas { minimal, got } => {
        format!("Transaction gas is too low. There is not enough gas to cover minimal cost of the transaction (minimal: {}, got: {}). Try increasing supplied gas.", minimal, got)
}
InsufficientGasPrice { minimal, got } => {
        format!("Transaction gas price is too low. It does not satisfy your node's minimal gas price (minimal: {}, got: {}). Try increasing the gas price.", minimal, got)
... (continued)

11281 of 45335 branches covered (24.88%)

Branch coverage included in aggregate %.

2940 of 4799 relevant lines covered (61.26%)

12533.18 hits per line