pywbem / nocasedict / 98
97%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 3
Run time 1s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
98

push

travis-ci

andy-maier 
Derived from MutableMapping; Removed support for initializing with None

Details:

* Changed the base class of NocaseDict from object to MutableMapping. That is
  the abstract base class for mutable dictionaries. Using that class does not
  introduce any instance attributes, like inheriting from the dict class would.
  Since a test for dictionaries should be done anyway by testing for
  inheritance from Mapping, that works fine and inheriting from dict is not
  necessary.

* In order to match the signatures of the inherited abstract methods, the
  following changes were made to NocaseDict method signatures:

  - setdefault():
    Old: def setdefault(self, key, default)
    New: def setdefault(sdef setdefault(self, key, default)

    The 'default' parameter now is optional with a default value of None.
    Previously, it was required. This is consistent with the 'dict' class (in
    Python 3.8).

  - update():
    Old: def update(self, *args, **kwargs)
    New: def update(self, other=(), **kwds)

    There is now only a single positional parameter instead of an arbitrary
    number, which is consistent with the definition in MutableMapping.
    Specifying more than one positional argument now causes TypeError
    to be raised. An according testcase has been added.

    The dict class (in Python 3.8) however only supports **either** a
    single positional parameter **or** a list of keyword parameters.

    The MutableMapping class uses the key() method on the single positional
    parameter if present. The previous im plementation of NocaseDict
    used the items() method. This was changed to also use keys().

    Adjusted the implementation accordingly and also simplified it and made
    it more pythonic.

* Removed support for initializing NocaseDict with `None` as a single
  positional argument, consistent with the behavior of the standard dict.
  Specifying `None` was already not supported for update(). Adjusted the
  testcases accordingly, which r... (continued)

163 of 168 relevant lines covered (97.02%)

0.97 hits per line

Jobs
ID Job ID Ran Files Coverage
3 98.3 (PACKAGE_LEVEL=latest) 0
97.02
 Travis Job 98.3
Source Files on build 98
Detailed source file information is not available for this build.