4367
50%

Ran 23 Jul 2020 04:40PM UTC

Jobs 5

Files 616

Run time 12min

Badge

Embed ▾

pending completion

Build # 4367

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Refactor importer APIs - Fixes #2963 (#2978)

* Make sure data directory is directory, not a file

* Add a test for zip archive import

Also tests the saving of the archive file name and source filename

* Add TODOs - no functional changes

* Cosmetic cleanups

* Revert importer API changes for archive file name parameter

Fixes #2963
- restore binary compatibility to the API
- hoist the handling of both fileSource and archiveFileName from
TabularImportingParserBase and TreeImportingParserBase to
ImportingParserBase so that there's only one copy. These 3 classes are
all part of the internal implementation, so there should be no
compatibility issue.

* Revert weird flow of control for import options metadata

This reverts the very convoluted control flow that was introduced
when adding the input options to the project metadata. Instead
the metadata is all handled in the importer framework rather than
having to change APIs are have individual importers worry about
it.

The feature never had test coverage, so that is still to be added.

* Add test for import options in project metadata & fix bug

Fixes bug where same options object was being reused and overwritten,
so all copies in the list ended up the same.

Coverage Stats

12506 of 25066 relevant lines covered (49.89%)

2.49 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	4367.1 (CODACY_PROJECT_TOKEN=[secure])	23 Jul 2020 04:40PM UTC	49.88	Travis Job 4367.1
2	4367.2 (CODACY_PROJECT_TOKEN=[secure])	23 Jul 2020 04:41PM UTC	49.87	Travis Job 4367.2
3	4367.3 (CODACY_PROJECT_TOKEN=[secure])	23 Jul 2020 04:46PM UTC	49.88	Travis Job 4367.3
4	4367.4 (CODACY_PROJECT_TOKEN=[secure])	23 Jul 2020 04:41PM UTC	49.87	Travis Job 4367.4
5	4367.5 (CODACY_PROJECT_TOKEN=[secure])	23 Jul 2020 04:41PM UTC	49.87	Travis Job 4367.5

Source Files on build 4367

Detailed source file information is not available for this build.

OpenRefine / OpenRefine / 4367
50%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4367

OpenRefine / OpenRefine / 4367 50%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4367

OpenRefine / OpenRefine / 4367
50%

README BADGES
x