12599
66%
master: 66%

Ran 23 Jul 2020 01:03AM UTC

Jobs 2

Files 111

Run time 54s

Badge

Embed ▾

Committed 23 Jul 2020 12:42AM UTC coverage: 65.881% (+0.05%) from 65.832%

Build # 12599

Build Type

push

travis-pro

Committed by

web-flow

Commit Message

Move CA RPC non-nil checks out of wrappers (#4971)

Introduces a new generic helper utility to check that
fields of proto messages are non-nil and non-zero.

Uses this helper to simplify the ca RPC wrapper
methods, moving their completeness checks into
the underlying method handler. Also annotates the
completeness checks to justify which fields are or
are not being checked for future readers. Finally,
removes the similar non-nil checks from the client
wrappers, where they provide no marginal value.

Follow-up changes will do the same for other RPC
services, migrate said services to proto3, and change
the IssueCertificateForPrecertificate method to return
a corepb.Certificate instead of a core.Certificate, like
the other methods on the ca service.

Issues: #4955

Run Details

13088 of 19866 relevant lines covered (65.88%)

1.48 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
13	12599.13 (RUN="coverage" CONTAINER="netaccess")	23 Jul 2020 01:03AM UTC	0	65.88	Travis Job 12599.13
14	12599.14 (RUN="coverage" CONTAINER="netaccess")	23 Jul 2020 01:04AM UTC	0	65.88	Travis Job 12599.14

Source Files on build 12599

Detailed source file information is not available for this build.

letsencrypt / boulder / 12599
66%
master: 66%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 12599

letsencrypt / boulder / 12599 66% master: 66%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 12599

letsencrypt / boulder / 12599
66%
master: 66%

README BADGES
x