250
95%

Ran 21 Jul 2020 04:42PM UTC

Jobs 8

Files 5

Run time 2min

Badge

Embed ▾

pending completion

Build # 250

Build Type

push

travis-ci-com

Committed by

Sekenre

Commit Message

Fix negative reference counts in C extension

In the C extension, `cbor2` creates several exceptions using
`PyErr_NewExceptionWithDoc`. Then it adds them to the module using
`PyModule_AddObject`, which steals a reference to the object (decrements
its reference count). Since `cbor2` later tries to decrement these
reference counts again in `cbor2_free`, they can become negative. This
results in undefined behaviour such as segmentation faults.

Fix this by incrementing the reference count for exceptions before
adding them to the module.

Fixes #89.

Run Details

745 of 746 relevant lines covered (99.87%)

7.28 hits per line

Jobs

ID	Job ID	Ran	Coverage
2	250.2 (TOXENV=pypy)	21 Jul 2020 04:43PM UTC	92.13	Travis Job 250.2
3	250.3 (TOXENV=pypy3)	21 Jul 2020 04:43PM UTC	88.93	Travis Job 250.3
4	250.4 (TOXENV=py27)	21 Jul 2020 04:43PM UTC	93.87	Travis Job 250.4
5	250.5 (TOXENV=py35)	21 Jul 2020 04:42PM UTC	94.27	Travis Job 250.5
6	250.6 (TOXENV=py36)	21 Jul 2020 04:42PM UTC	89.87	Travis Job 250.6
7	250.7 (TOXENV=py37)	21 Jul 2020 04:44PM UTC	89.87	Travis Job 250.7
8	250.8 (TOXENV=py38)	21 Jul 2020 04:44PM UTC	90.1	Travis Job 250.8
9	250.9 (TOXENV=py38)	21 Jul 2020 04:43PM UTC	90.1	Travis Job 250.9

Source Files on build 250

Detailed source file information is not available for this build.

agronholm / cbor2 / 250
95%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 250

agronholm / cbor2 / 250 95%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 250

agronholm / cbor2 / 250
95%

README BADGES
x