1180
81%
master: 81%

Ran 16 Jul 2020 04:56PM UTC

Jobs 1

Files 22

Run time 33min

Badge

Embed ▾

pending completion

Build # 1180

Build Type

push

travis-ci-com

Committed by

GPMueller

Commit Message

Core: bugfixes for removing systems from the chain.
The issue probably existed due to the somewhat unclear names `Simulation_Running_On_Chain` (checks chain only) and `Simulation_Running_On_Image` (checks specified image only, not checking for simulations running on the entire chain), which are mutually exclusive.
When removing systems from a chain, running calculations may need to be stopped beforehand. So far, the checks were incomplete, in particular when calculations on individual images were running (which were therefore not stopped). The method could still hold a shared pointer to the image and continue running, meaning the GUI thread controlling the calculation could stall the GUI.
It seems these bugs were avoided in the Qt GUI by placing additional checks around the API calls, which should not be needed.
Note, when increasing the chain length, one only needs to check that no calculation is running across the whole chain.

Run Details

1046 of 1317 relevant lines covered (79.42%)

0.79 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
7	1180.7 (PYPIUSER=[secure] PYPIPASSWORD=[secure] COMPILER_C=gcc-6 COMPILER_CXX=g++-6 CMAKE_OPTIONS="-DSPIRIT_UI_CXX_USE_QT=OFF -DSPIRIT_TEST_COVERAGE=ON" PYPI=false COVERAGE=true RUNTESTS=false)	16 Jul 2020 04:56PM UTC	0	79.42	Travis Job 1180.7

Source Files on build 1180

Detailed source file information is not available for this build.

spirit-code / spirit / 1180
81%
master: 81%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1180

spirit-code / spirit / 1180 81% master: 81%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1180

spirit-code / spirit / 1180
81%
master: 81%

README BADGES
x