4184
31%

Ran 16 Jul 2020 12:21PM UTC

Jobs 1

Files 82

Run time 31s

Badge

Embed ▾

Committed 16 Jul 2020 12:05PM UTC coverage: 28.193% (+0.08%) from 28.114%

Build # 4184

Build Type

push

travis-pro

Committed by

web-flow

Commit Message

Fix limit price estimation regression (#1140)

This PR fixes a limit price estimation regression introduced in the recent refactoring. This is because we were `?`-short circuiting on an `Option` that was always `None` (since we don't fill transitive orders when volume is `0.0`).

### Test Plan

New unit test introduced to catch similar regressions.

Coverage Stats

10269 of 41678 branches covered (24.64%)

Branch coverage included in aggregate %.

2745 of 4483 relevant lines covered (61.23%)

13429.49 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
3	4184.3 (OPEN_SOLVER_VERSION=v0.0.10 PRIVATE_SOLVER_VERSION=v0.8.1)	16 Jul 2020 12:21PM UTC	0	28.19	Travis Job 4184.3

Source Files on build 4184

Detailed source file information is not available for this build.

gnosis / dex-services / 4184
31%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4184

gnosis / dex-services / 4184 31%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4184

gnosis / dex-services / 4184
31%

README BADGES
x