dart-lang / dartdoc / 4439

66%

push

travis-ci

Performance improvements (#2259)

When documenting the camera Flutter plugin, these changes reduce the time to
document from 52 seconds to 51 seconds.

Much of this speedup likely came from memoizing Package.documentedWhere, which
has a few expensive calls like `linkToRemote` and `linkToUrl`. Additionally
ModelElement.locationPieces is now memoized.

The rest is a few refactorings:

* ModelElement.canonicalLibrary:
    * Refactor most of the complexity of ModelElement.canonicalLibrary into a
      new private method.
    * Don't compute topLevelElement until you need it.
    * Short circuit if `definingLibrary.exportedInLibraries` is null.
    * Reduce nesting
    * Create warning message only if it will be used.
* Prefer for loops over Iterable.forEach.

67 of 67 new or added lines in 6 files covered. (100.0%)

5922 of 6390 relevant lines covered (92.68%)

16.92 hits per line