251
96%

Ran 30 Jun 2020 04:42PM UTC

Jobs 1

Files 8

Run time 16min

Badge

Embed ▾

pending completion

Build # 251

Build Type

push

travis-ci

Committed by

chriswmackey

Commit Message

fix(model): Remove global_construction_set key from Model properties

This commit removes the `global_construction_set` key on the Model object and gets rid of the corresponding bugs they create.

The aim is that the default objects typically expressed in this global set are now constant across all machines, plugins and libraries now that they live in their own JSON files that all developers can load from [here](https://github.com/ladybug-tools/honeybee-standards/blob/master/honeybee_standards/energy_default.json).  This will ensure that everyone is in agreement about these defaults across plugins without the need to repeat them in the schema of individual models.

So now, if users want to override the default Constructions/Modifiers, the recommendation is to do them with a ConstructionSet or ModifierSet object applied to a Dragonfly Room2D, Story or Building.

CC: @MingboPeng , @ksobon, @theo-armour

Run Details

188 of 200 relevant lines covered (94.0%)

0.94 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	251.1	30 Jun 2020 04:42PM UTC	0	94.0	Travis Job 251.1

Source Files on build 251

Detailed source file information is not available for this build.

ladybug-tools / dragonfly-schema / 251
96%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 251

ladybug-tools / dragonfly-schema / 251 96%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 251

ladybug-tools / dragonfly-schema / 251
96%

README BADGES
x