12446
66%

Ran 29 Jun 2020 07:48PM UTC

Jobs 1

Files 111

Run time 19s

Badge

Embed ▾

Committed 29 Jun 2020 07:42PM UTC coverage: 66.036% (-0.02%) from 66.052%

Build # 12446

Build Type

push

travis-pro

Committed by

web-flow

Commit Message

Remove OCSPStaleMaxAge config value and handling (#4911)

The OCSPStaleMaxAge config value was added in #2419 as part of an
effort to ensure that ocsp-updater's queries of the certificateStatus
table were efficient. It was never intended as a long-term fix:
in #2431 and #2432 the query was updated to index on the much more
efficient isExpired and notAfter columns if a feature flag was set,
and in #2561 that code path was made the default and the flag removed.

However, the `WHERE ocspLastUpdate > ocspStaleMaxAge` clause has
remained in the query. This is redundant, as the ocspStaleMaxAge has
always been set to 5040 hours, or 210 days, significantly longer than
the 90-day expiration of Let's Encrypt certs.

This change removes that clause from the query, and removes the config
scaffolding around it. In addition, it updates the tests to remove
workarounds necessitated by this column, and simplifies and documents
them for future readers.

Fixes #4884

Run Details

12986 of 19665 relevant lines covered (66.04%)

0.74 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
7	12446.7 (RUN="coverage" CONTAINER="netaccess")	29 Jun 2020 07:48PM UTC	0	66.04	Travis Job 12446.7

letsencrypt / boulder / 12446
66%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 12446

letsencrypt / boulder / 12446 66%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 12446

letsencrypt / boulder / 12446
66%

README BADGES
x