• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

gnosis / dex-contracts / 4909
100%

Build:
DEFAULT BRANCH: master
Ran 29 Jun 2020 02:50PM UTC
Jobs 1
Files 7
Run time 13min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
4909

push

travis-ci

web-flow
[Viewer] Convenience method to get tokenInfo for a tokenID (#860)

I'm planning to use this method in dex-services when we want to get the symbol and decimals for each token. At the moment it would require three calls:

1. turn tokenId into tokenAddress
2. Get symbol for tokenAddress
3. Get decimals for tokenAddress

While 2./3. could happen in one batch they depend on the result of query 1. With this change we can query token Info atomically in one call.

I thought about allowing to pass in an array and return an array of symbols, decimals and addresses, however the return type string[] is only available in the experimental ABI. The alternative would be to byte encode this information similar to how we do for order information, however this did not feel worth the overhead it would add consuming this method (and multiple tokenId requests can be batched into one roundtrip).

### Test Plan

Added unit test.

98 of 98 branches covered (100.0%)

Branch coverage included in aggregate %.

264 of 264 relevant lines covered (100.0%)

81.86 hits per line

Jobs
ID Job ID Ran Files Coverage
1 4909.1 (NODE_OPTIONS=--max_old_space_size=4096) 29 Jun 2020 02:50PM UTC 0
100.0
Travis Job 4909.1
Source Files on build 4909
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #4909
  • c64b3746 on github
  • Prev Build on master (#4906)
  • Next Build on master (#4910)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc