twitter / finatra / 601

61%

develop: 81%

push

travis-ci

finatra/http: remove ExceptionMapper.replace

Problem:

ExceptionManager.replace is too fragile because it relies on module
initialization order.

Solution:

Remove ExceptionManager.replace. Fold HttpException, HttpResponseException,
CancelledRequestException into FinatraDefaultExceptionMapper to
enforce built-in exception handling that shouldn't be configurable.

Result:

ExceptionManager.replace is gone. Users can write their own modules
if the default module isn't suitable.

RB_ID=720818

15 of 15 new or added lines in 3 files covered. (100.0%)

1741 of 2159 relevant lines covered (80.64%)

4.82 hits per line