3598
92%
master: 98%

Ran 28 Jul 2015 06:01PM UTC

Jobs 2

Files 190

Run time 47s

Badge

Embed ▾

pending completion

Build # 3598

Build Type

push

travis-ci

Committed by

hectorcorrea

Commit Message

After a week of training on "Practical Object-Oriented Design" with Sandi Metz @cam156 @awead and I decided to take a stab at refactoring a small piece of functionality with some of the ideas that we learned.

This PR does not change the functionality of the MailboxController but it refactors most of the code out of it to a model class UserMailbox This new class encapsulates most of the functionality and the controller is now as skinny as it gets which was one of our goals.

The new UserMailbox has a more comprehensive list of tests than the original code and it's easier to test since it does not mix model + controller functionality.

Run Details

3468 of 3789 relevant lines covered (91.53%)

74.83 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	3598.1 (2.2, RAILS_VERSION=4.2.3)	28 Jul 2015 06:01PM UTC	0	91.53	Travis Job 3598.1
2	3598.2 (2.1, RAILS_VERSION=4.2.3)	28 Jul 2015 06:01PM UTC	0	91.53	Travis Job 3598.2

Source Files on build 3598

Detailed source file information is not available for this build.

projecthydra / sufia / 3598
92%
master: 98%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 3598

projecthydra / sufia / 3598 92% master: 98%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 3598

projecthydra / sufia / 3598
92%
master: 98%

README BADGES
x