cucumber / cucumber-jvm / 4186

86%

push

travis-ci

[Core] Generate valid parameter names in snippets (#2029)

Parameter names were taken directly form the parameter names used in the
cucumber expression. By passing these through the identifier generator
we can ensure that these are valid identifiers.

To reflect this new usage the `FunctionNameGenerator` was renamed to
`IdentifierGenerator`. The identifier generator uses a strategy pattern to join
words into method and parameter names.

Parameter names are always generated using the camel case strategy. While
long sentence like method names may be more readable in snake case, it is
expected that people will still want to follow the java conventions for
parameters.

To avoid issues where a parameter name were already in camel case or underscore
case sentences are also split on camel case and underscores (in addition to
whitespace). This also required using all lower case in the `UnderscoreJoiner`
which has since been renamed to `SnakeCaseJoiner`.

Fixes: #2028

55 of 55 new or added lines in 4 files covered. (100.0%)

6806 of 7911 relevant lines covered (86.03%)

0.86 hits per line