Cryptonomic / Conseil / 3281
65%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 71
Run time 13s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
3281

push

travis-ci

web-flow 
843 - 844 - Missing proposals data from governance and fix incorrect rolls counts per level (#845)

* Refactor governance processing to reduce argument passing

 * include minor renames and refactors

* Address all review comments

* Revert database operations unrelated changes

* Refactor most governance process logic to clean it up

 * Remove unneeded operations or data, and only pass the minimal
   set of arguments for each given operation
 * Document the code and especially make explicit any relevant
   assumption
 * Separate and move "modules" of code to appropriate classes: create
   a module to process governance data, move the logic there out from
   the conversion to db data, remove as much as possible from the
   indexer object

* Consider any block for voting ballots, and get proposals' data

 * pass all blocks with optional proposal to the governance aggregator
   and compute values on all those, not only those with a running
   proposal to vote

* Minor rephrasing

* Minor improvement from review

* Address review comments regarding naming of variables

* 843 - Correct rolls counts from governance (#851)

* Use existing rolls counts in governance rows to correctly compute diffs

 * When computing rolls of ballot votes per level, take into account
   that the rolls are missing for the level just before the lowest
   accounted for in the blocks being processed
 * Add useful operations to the VotesRollsCounts object to make
   subtraction easy

* Minor rename

* Adding more extensive doc comments as per review comments

1956 of 2971 relevant lines covered (65.84%)

0.66 hits per line

Jobs
ID Job ID Ran Files Coverage
1 3281.1 0
65.84
 Travis Job 3281.1
Source Files on build 3281
Detailed source file information is not available for this build.