#7700
88%
master: 83%

Ran 16 Jun 2020 02:00PM UTC

Jobs 1

Files 73

Run time 44s

Badge

Embed ▾

Committed 16 Jun 2020 01:42PM UTC coverage: 87.712% (+0.02%) from 87.692%

Build # #7700

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Fix Secure Session serialization format (#658)

secure_session_save() saves short serialized Secure Session state.

That is, it writes "is_client" as 4-byte value while its size in
SESSION_CTX_SERIZALIZED_SIZE is computed as sizeof(bool) which is 1 byte
on most platforms. This causes 3 least significant bytes of "in_seq"
being missing from the serialized data.

Correct size of Secure Session state is 60 bytes, we report only 57.

This issue is not detected by unit tests of JavaThemis -- the only
high-level wrapper supporting this interface -- which works only because
the allocated memory for the output array is slightly bigger than
requested 57 bytes, extra 3 bytes written past-the-end remain there
in RAM and the unit test generally works, if the data stays where it is.
However, sometimes garbage collection occurs at the right moment and the
issue manifests itself as a failing Secure Session test.

Now the output size is reported correctly and all Secure Session data is
written within the allocated bounds.

Run Details

3776 of 4305 relevant lines covered (87.71%)

19298.09 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	#7700.1	16 Jun 2020 02:00PM UTC	0	87.71

Source Files on build #7700

Detailed source file information is not available for this build.

cossacklabs / themis / #7700
88%
master: 83%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build #7700

cossacklabs / themis / #7700 88% master: 83%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build #7700

cossacklabs / themis / #7700
88%
master: 83%

README BADGES
x