• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

yannickcr / eslint-plugin-react / 4230
97%

Build:
DEFAULT BRANCH: master
Ran 15 Jun 2020 10:12PM UTC
Jobs 23
Files 106
Run time 6min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
4230

push

travis-ci

lencioni
Cache detected React version

I've been timing and profiling ESLint runs at Airbnb and noticed that
react/no-unknown-property is particularly slow for us when using the
"detect" setting for React version.

When running ESLint using TIMING=1 on a directory that contains about
500 files to be linted in it, react/no-unknown-property shows up as
taking about 1700ms.

Looking at the callstacks in the profiler, it seems that when this rule
calls getStandardName for every JSXAttribute here, it will actually do
all of the work to detect the React version every time to determine the
correct set of DOM property names. Since there may be a lot of
JSXAttribute nodes in a codebase, this adds up to quite a bit of work.

By specifying the react version in our ESLint config, the
no-unkown-property rule drops out of the top 10 slowest rules entirely,
with the 10th slowest clocking in at 180ms.

I think it would be a good idea to cache the React version when using
detect instead of looking it up every time.

4434 of 4659 branches covered (95.17%)

9 of 9 new or added lines in 1 file covered. (100.0%)

5231 of 5359 relevant lines covered (97.61%)

11713.64 hits per line

Jobs
ID Job ID Ran Files Coverage
1 4230.1 (TEST=true ESLINT=7) 15 Jun 2020 10:12PM UTC 0
97.59
Travis Job 4230.1
2 4230.2 (TEST=true ESLINT=6) 15 Jun 2020 10:12PM UTC 0
97.59
Travis Job 4230.2
3 4230.3 (TEST=true ESLINT=5) 15 Jun 2020 10:12PM UTC 0
97.59
Travis Job 4230.3
4 4230.4 (TEST=true ESLINT=4) 15 Jun 2020 10:12PM UTC 0
97.5
Travis Job 4230.4
5 4230.5 (TEST=true ESLINT=7) 15 Jun 2020 10:12PM UTC 0
97.59
Travis Job 4230.5
6 4230.6 (TEST=true ESLINT=6) 15 Jun 2020 10:13PM UTC 0
97.59
Travis Job 4230.6
7 4230.7 (TEST=true ESLINT=5) 15 Jun 2020 10:13PM UTC 0
97.59
Travis Job 4230.7
8 4230.8 (TEST=true ESLINT=4) 15 Jun 2020 10:13PM UTC 0
97.5
Travis Job 4230.8
9 4230.9 (TEST=true ESLINT=7) 15 Jun 2020 10:14PM UTC 0
97.59
Travis Job 4230.9
10 4230.10 (TEST=true ESLINT=6) 15 Jun 2020 10:14PM UTC 0
97.59
Travis Job 4230.10
11 4230.11 (TEST=true ESLINT=5) 15 Jun 2020 10:15PM UTC 0
97.59
Travis Job 4230.11
12 4230.12 (TEST=true ESLINT=4) 15 Jun 2020 10:15PM UTC 0
97.5
Travis Job 4230.12
13 4230.13 (TEST=true ESLINT=6) 15 Jun 2020 10:15PM UTC 0
97.59
Travis Job 4230.13
14 4230.14 (TEST=true ESLINT=5) 15 Jun 2020 10:15PM UTC 0
97.59
Travis Job 4230.14
15 4230.15 (TEST=true ESLINT=4) 15 Jun 2020 10:15PM UTC 0
97.5
Travis Job 4230.15
16 4230.16 (TEST=true ESLINT=5) 15 Jun 2020 10:16PM UTC 0
97.59
Travis Job 4230.16
17 4230.17 (TEST=true ESLINT=4) 15 Jun 2020 10:16PM UTC 0
97.5
Travis Job 4230.17
19 4230.19 (TEST=true PRETEST=true) 15 Jun 2020 10:16PM UTC 0
97.59
Travis Job 4230.19
20 4230.20 (TEST=true README=true) 15 Jun 2020 10:16PM UTC 0
97.59
Travis Job 4230.20
21 4230.21 (TEST=true ESLINT=7) 15 Jun 2020 10:17PM UTC 0
97.59
Travis Job 4230.21
22 4230.22 (TEST=true ESLINT=6) 15 Jun 2020 10:17PM UTC 0
97.59
Travis Job 4230.22
23 4230.23 (TEST=true ESLINT=5) 15 Jun 2020 10:17PM UTC 0
97.59
Travis Job 4230.23
24 4230.24 (TEST=true ESLINT=4) 15 Jun 2020 10:17PM UTC 0
97.5
Travis Job 4230.24
Source Files on build 4230
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #4230
  • b8e91a57 on github
  • Prev Build on master (#4219)
  • Next Build on master (#4245)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc