apache / bookkeeper / 841
72%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 545
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
841

push

jenkins

GitHub 
[BUG] Fix redundant statistics

### Motivation

Fix redundant statistics, run 5 bookies `bin/bookkeeper localbookie 10`, then show bookieinfo

```
./bin/bookkeeper shell bookieinfo
```

**Wrong result**
```
Free disk space info:
10.101.52.18(10.101.52.18):5004:        Free: 34930151424(34.93GB)      Total: 255850758144(255.85GB)
10.101.52.18(10.101.52.18):5003:        Free: 34930151424(34.93GB)      Total: 255850758144(255.85GB)
10.101.52.18(10.101.52.18):5002:        Free: 34930151424(34.93GB)      Total: 255850758144(255.85GB)
10.101.52.18(10.101.52.18):5000:        Free: 34930151424(34.93GB)      Total: 255850758144(255.85GB)
10.101.52.18(10.101.52.18):5005:        Free: 34930151424(34.93GB)      Total: 255850758144(255.85GB)
Total free disk space in the cluster:   174650757120(174.65GB)
Total disk capacity in the cluster:     1279253790720(1.279TB)
```

**Right result**
```
Free disk space info:
10.101.52.18(10.101.52.18):5004:        Free: 33172185088(33.172GB)     Total: 255850758144(255.85GB)
10.101.52.18(10.101.52.18):5003:        Free: 33172185088(33.172GB)     Total: 255850758144(255.85GB)
10.101.52.18(10.101.52.18):5002:        Free: 33172185088(33.172GB)     Total: 255850758144(255.85GB)
10.101.52.18(10.101.52.18):5006:        Free: 33172185088(33.172GB)     Total: 255850758144(255.85GB)
10.101.52.18(10.101.52.18):5005:        Free: 33172185088(33.172GB)     Total: 255850758144(255.85GB)
Total free disk space in the cluster:   33172185088(33.172GB)
Total disk capacity in the cluster:     255850758144(255.85GB)
```



Reviewers: Jia Zhai <zhaijia@apache.org>, Sijie Guo <None>, Enrico Olivelli <eolivelli@gmail.com>

This closes #2348 from lamber-ken/bk-info-command

10 of 10 new or added lines in 1 file covered. (100.0%)

28438 of 39721 relevant lines covered (71.59%)

0.72 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
10
0.0
 0.0% bookkeeper-server/src/main/java/org/apache/bookkeeper/tools/cli/commands/bookies/InfoCommand.java

Uncovered Existing Lines

Lines Coverage ∆ File
1
88.28
 -0.21% bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
1
92.31
 -0.38% bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/IndexInMemPageMgr.java
1
82.76
 -3.45% bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/SlowBufferedChannel.java
1
91.46
 -1.22% bookkeeper-server/src/main/java/org/apache/bookkeeper/client/DefaultEnsemblePlacementPolicy.java
1
88.65
 -0.71% bookkeeper-server/src/main/java/org/apache/bookkeeper/client/ReadOnlyLedgerHandle.java
1
86.3
 -1.37% bookkeeper-server/src/main/java/org/apache/bookkeeper/client/SyncCallbackUtils.java
2
88.51
 -0.85% bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java
2
80.0
 -1.25% bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/TransactionalEntryLogCompactor.java
2
81.97
 -0.66% bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/ReplicationWorker.java
3
88.84
 -0.6% bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java
3
69.35
 -2.42% bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookieWatcherImpl.java
3
95.45
 -4.55% bookkeeper-server/src/main/java/org/apache/bookkeeper/client/MetadataUpdateLoop.java
3
65.26
 -1.05% bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/AbstractZkLedgerManager.java
3
69.69
 -0.54% bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/ZkLedgerUnderreplicationManager.java
3
86.56
 -0.27% bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java
4
84.62
 -1.28% bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/IndexPersistenceMgr.java
6
83.72
 -13.95% bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingWriteLacOp.java
7
0.0
 0.0% bookkeeper-server/src/main/java/org/apache/bookkeeper/tools/cli/commands/bookies/InfoCommand.java
14
78.97
 -1.13% bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/Auditor.java
Jobs
ID Job ID Ran Files Coverage
1 841.1 545
71.59
Source Files on build 841