OverLordGoldDragon / see-rnn / 286

96%

push

travis-ci-com

Fix L1-norm case in `weights_norm`

`norm_fn=np.abs` would compute L1 norm as: `np.sqrt(np.sum(np.abs(x)))`, which is incorrect; the sqrt is redundant. `norm_fn=np.abs` will now work correctly. L2-norm case always worked correctly.

For L2-norm, set `norm_fn = (np.sqrt, np.square) = (outer_fn, inner_fn)`, which will compute `outer_fn(sum(inner_fn(x)))`. Note that `norm_fn=np.square` will **no longer compute L2-norm correctly**.

Pardon the mishap.

5 of 5 new or added lines in 2 files covered. (100.0%)

1409 of 1436 relevant lines covered (98.12%)

5.72 hits per line