3967
49%

Ran 09 Jun 2020 05:55AM UTC

Jobs 1

Files 573

Run time 37s

Badge

Embed ▾

pending completion

Build # 3967

Build Type

cron

travis-ci

Committed by

web-flow

Commit Message

[ISSUE #1976]System topic should add permission checking globally (#1985)

* fix #1976
System Topic like SCHEDULE_TOPIC_XXXX should not be create or delete by user

* User can not send message to system topic SCHEDULE_TOPIC_XXXX

* the-->The

* fix magic number 18

* move system topic to TopicValidator except TBW102

* move TBW102 and isSystemTopic to TopicValidator

* add test code

* validateTopic --> validatorSystemTopic, validatorBlacklistTopic

* validateTopic --> validatorSystemTopic, validatorBlacklistTopic

* rename some methods

Run Details

116 of 116 new or added lines in 19 files covered. (100.0%)

17567 of 34294 relevant lines covered (51.22%)

0.51 hits per line

New Missed Lines in Diff

Lines	Coverage	∆	File
1	50.0	0.0%	broker/src/main/java/org/apache/rocketmq/broker/processor/AbstractSendMessageProcessor.java
1	68.97	0.0%	broker/src/main/java/org/apache/rocketmq/broker/topic/TopicConfigManager.java
1	67.39	0.0%	client/src/main/java/org/apache/rocketmq/client/Validators.java
1	5.14	0.0%	client/src/main/java/org/apache/rocketmq/client/impl/MQAdminImpl.java
1	15.01	0.0%	client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java
1	53.77	0.0%	client/src/main/java/org/apache/rocketmq/client/impl/factory/MQClientInstance.java
1	41.68	0.0%	client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java
1	75.03	0.0%	store/src/main/java/org/apache/rocketmq/store/CommitLog.java
1	81.87	0.0%	store/src/main/java/org/apache/rocketmq/store/dledger/DLedgerCommitLog.java
2	8.62	0.0%	broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java
2	95.83	0.0%	common/src/main/java/org/apache/rocketmq/common/topic/TopicValidator.java
2	64.58	0.0%	store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java

Uncovered Existing Lines

Lines	Coverage	∆	File
1	80.0	0.0%	broker/src/main/java/org/apache/rocketmq/broker/transaction/queue/TransactionalMessageUtil.java
1	41.3	-2.17%	common/src/main/java/org/apache/rocketmq/common/stats/MomentStatsItemSet.java
1	43.65	-0.79%	common/src/main/java/org/apache/rocketmq/common/stats/StatsItemSet.java
2	67.39	0.0%	client/src/main/java/org/apache/rocketmq/client/Validators.java
12	74.19	0.0%	common/src/main/java/org/apache/rocketmq/common/protocol/NamespaceUtil.java
13	50.18	-4.69%	client/src/main/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessageOrderlyService.java
17	83.85	0.0%	store/src/main/java/org/apache/rocketmq/store/schedule/ScheduleMessageService.java
23	50.0	0.0%	broker/src/main/java/org/apache/rocketmq/broker/processor/AbstractSendMessageProcessor.java
42	81.87	0.0%	store/src/main/java/org/apache/rocketmq/store/dledger/DLedgerCommitLog.java
45	68.97	0.0%	broker/src/main/java/org/apache/rocketmq/broker/topic/TopicConfigManager.java
54	45.73	0.0%	client/src/main/java/org/apache/rocketmq/client/producer/DefaultMQProducer.java
61	50.46	0.0%	broker/src/main/java/org/apache/rocketmq/broker/processor/PullMessageProcessor.java
69	53.95	0.0%	common/src/main/java/org/apache/rocketmq/common/MixAll.java
79	5.14	0.0%	client/src/main/java/org/apache/rocketmq/client/impl/MQAdminImpl.java
131	75.03	0.0%	store/src/main/java/org/apache/rocketmq/store/CommitLog.java
139	33.23	0.0%	common/src/main/java/org/apache/rocketmq/common/BrokerConfig.java
147	41.68	0.0%	client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java
178	64.58	0.0%	store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java
350	8.62	0.0%	broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java

Jobs

ID	Job ID	Ran	Files	Coverage
1	3967.1 (CUSTOM_JDK="oraclejdk8")	09 Jun 2020 05:55AM UTC	573	51.22	Travis Job 3967.1

apache / rocketmq / 3967
49%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Uncovered Existing Lines

Jobs

Source Files on build 3967

apache / rocketmq / 3967 49%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Uncovered Existing Lines

Jobs

Source Files on build 3967

apache / rocketmq / 3967
49%

README BADGES
x