3585
82%

Ran 09 Jun 2020 05:00AM UTC

Jobs 3

Files 1

Run time 11s

Badge

Embed ▾

Committed 09 Jun 2020 04:56AM UTC coverage: 82.09%. Remained the same

Build # 3585

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Fix some bytecompiler warnings/gccemacs errors (#1767)

* [Cask] Compile lsp-{protocol, mode}.el first

this exposes ordering issues that might otherwise get masked by other
lsp-*.el files requiring lsp-mode.el before lsp-mode.el itself is
byte-compiled. In its current form, the Cask file will now lead to
lsp-mode.el and lsp-protocol.el being compiled twice, but I don't
believe this causes any issues except for the extra second or so of
compile time.

I'd rather not list all *.el files explicitly; instead, I'd prefer Cask
to ignore duplicate files automatically (or, in an ideal world, to
analyze `require` forms automatically, warn about cycles and otherwise
compile in the correct order).

* Eval-when-compile dash-expand:&lsp-*

this fixes 10 compiler warnings (and actual runtime errors on gccemacs).
Thanks to @yyoncho and @ericdallo for figuring out this issue

* Fix several reference-to-free-variable warnings

this separates a number of defcustoms from the accompanying
logic (lsp-signature in particular), so feel free to drop
this commit if you think it hurts readability

* Fix late macro definitions

lsp-with-current-buffer, lsp-with-filename

Run Details

55 of 67 relevant lines covered (82.09%)

437.96 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	3585.1 (EMACS_VERSION=25.1)	09 Jun 2020 05:00AM UTC	82.09	Travis Job 3585.1
2	3585.2 (EMACS_VERSION=25.2)	09 Jun 2020 05:00AM UTC	82.09	Travis Job 3585.2
3	3585.3 (EMACS_VERSION=25.3)	09 Jun 2020 05:00AM UTC	82.09	Travis Job 3585.3

Source Files on build 3585

Detailed source file information is not available for this build.

emacs-lsp / lsp-mode / 3585
82%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 3585

emacs-lsp / lsp-mode / 3585 82%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 3585

emacs-lsp / lsp-mode / 3585
82%

README BADGES
x