dashofcode / tracker_api / 361

97%

push

travis-ci

Reviews (#137)

* Mocha require by version logic was trying to require the incorrect file for recent versions of Mocha. Semantic versioning cannot be evaluated by greater than/less than comparisons i.e 1.11 is less than 1.9 as floats but not as semantic versions.

Reverting to original require syntax as this appears to be the valid syntax for most recent versions of Mocha. Deprecation warnings squelched by the original commit seem more tenable than additional logic in the test helper.

* Adds reviews so someone can fetch story.reviews.

A review_type is tightly coupled to a review. It is accessible as a field customization for reviews but not accessible via a distinct api endpoint. Since it is difficult to understand a review without the review_type, I made the decision to include default review fields and review_type when calling get story/{story_id}/ reviews. The review types are hydrated automatically.

Authored-by: Michael McCormick <oss@whatsis.org>

55 of 55 new or added lines in 6 files covered. (100.0%)

1656 of 1707 relevant lines covered (97.01%)

1264.65 hits per line