optimizely / javascript-sdk / 1901

78%

push

travis-ci

fix: Stub event dispatcher and mock timers in tests (#497)

Summary

- Several unit tests weren't properly stubbing the default event dispatcher - add these stubs

- The test suite wasn't exiting due to active timers not being cleaned up. Fixed this by mocking setTimeout using sinon.useFakeTimers

- One test for Node default event dispatcher was relying on a real connection error from attempting to request to an invalid domain. Added a nock mock for this to prevent the real request.

Test plan:

Run npm test. Should exit immediately, and not make any outgoing HTTP requests.

Issues:

https://github.com/optimizely/javascript-sdk/issues/487

681 of 778 branches covered (87.53%)

Branch coverage included in aggregate %.

6849 of 7009 relevant lines covered (97.72%)

107.45 hits per line