biocore / emperor / 1560

92%

push

travis-ci-com

Fix color sorting in the legend (#765)

* BUG: Make naturalSort treat +/-Infinity as words

Modified the function and added a unit test verifying this.
Both modifications are from Empress' codebase, specifically in
the PR https://github.com/biocore/empress/pull/159.

* MNT: Update Chroma.js to v2.1.0 (from v1.1.1) #762

As expected, this causes the JS tests to fail due to small precision
differences. Will need to update those.

* BUG: Fix interpolation for "ordinal" color scaling

Closes #760. Tests are broken, though, so will need to fix those
(along with tests broken from fixing #762).

* MNT: use "Viridis" instead of "viridis" as default

Both seem to be accepted by Chroma.js, but may as well be consistent
with what their docs use (also, the Emperor docstrings said "Viridis"
in spite of this not being followed).

* TST: Fix getInterpolatedColors() test for #760

* TST: More CVC test fixes for #760/#762

Also added an empress code attribution to getInterpolatedColors()

* TST: Partial work on fixing expected gradient SVGs

emphasis on "partial", would prefer to automate this

* TST: Update gradient SVGs to use new colors

Just did this by copying in the new output (finagled it to roughly
match the old expected output's formatting for purposes of making
the diff cleaner).

Now that tests pass, I'm gonna say that this officially closes #762 :)

* MNT: only call parseFloat() once in naturalSort()

Addresses comment from @wasade

* TST: Test naturalSort() with sci. notation numbers

Addresses @wasade's comment.

NOTE that #761 is still gonna mess things up, though. Will comment
accordingly in #763.

* BUG: Sort field vals in DecompView.setCategory

Fixes #761. May be worth adding tests at some point, but since this
change didn't break any tests I guess this would require writing new
tests rather than updating any current ones.

* TST: Add infrastructure for #761 regression test

Still need to, l... (continued)

203 of 219 branches covered (92.69%)

439 of 477 relevant lines covered (92.03%)

4.6 hits per line