vanvalenlab / kiosk-benchmarking / 379

97%

push

travis-ci-com

Improve the CLI interface, use API for uploading files. (#45)

* only save `MODEL` in settings, split the model name and version in Manager.

* remove repeated env var `UPLOAD_PREFIX`

* change order of Manager init for clarity.

* add `setup.py`

* add all env vars from `settings.py`

* test against 2.7 and 3.8 for more robust CLI support

* `model_name` and `model_version` refactored to `model`

* move `_strip` lambda into utils as `strip_bucket_prefix`, use on init for jobs and managers.

* use `defer.returnValue(result)` in `job.restart`

* use `pytest.tmpdir` instead of `tempfile.TemporaryDirectory`

* `JSONDecodeError` is a `ValueError`, but does not exist in python 2.x

* DEBUG env var is unused and undocumented.

* add storage_bucket as an optional manager kwarg

* only include GPUs in output filename if NUM_GPUS is set.

* add upload_results attribute to optionally upload the final file to the bucket.

* define all env vars as argparse options and include in entrypoint.

* move uploading logic into Job. use API for file uploads instead of `gcloud`.

* add calculate_cost to conditionally use the Grafana API.

* log times in each Job HTTP request

* allow `scale` to be an empty string, but otherwise, cast to float.

* promote `job_type` to primary input, and `model` as override option.

89 of 89 new or added lines in 5 files covered. (100.0%)

579 of 596 relevant lines covered (97.15%)

4.85 hits per line