wooga / atlas-version / 12
76%

DEFAULT BRANCH: master
Ran
Jobs 4
Files 15
Run time 953057min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
12

push

jenkins

Fix Snapshot branchname strategy (#5)

Description
===========

The `PartialSemVerStrategy` `STAGE_BRANCH_NAME` tries to generate a
unique semver 2.0 prerelease pattern. The provided tests where mostly
written in an optimistic fashion. This patch fixes the strategy when
branch names are in use which contain unusual characters or character
combinations.

As an example:

The branchName `feature/button_01` would yield a prerelease part of:
`branch.feature.button.01` which is not semver 2 compatible. Numerical
parts are not allowed to be `0` padded. The strategy also kept hanging
characters like `-`,`+`,`_`.

This patch tries to fix this cases.

_excerpt from the tests in `ReleasePluginSpec`

```
_  | 10   | "ci"  | _  | "test/build01-"            | "1.1.0-branch.test.build.1.10"
_  | 22   | "ci"  | _  | "test/build01+"            | "1.1.0-branch.test.build.1.22"
_  | 45   | "ci"  | _  | "test/build01_"            | "1.1.0-branch.test.build.1.45"
_  | 204  | "ci"  | _  | "test/build01"             | "1.1.0-branch.test.build.1.204"
_  | 100  | "ci"  | _  | "test/build.01"            | "1.1.0-branch.test.build.1.100"
_  | 55   | "ci"  | _  | "test/build002"            | "1.1.0-branch.test.build.2.55"
_  | 66   | "ci"  | _  | "test/build.002"           | "1.1.0-branch.test.build.2.66"
_  | 789  | "ci"  | _  | "test/build000000000003"   | "1.1.0-branch.test.build.3.789"
_  | 777  | "ci"  | _  | "test/build.000000000003"  | "1.1.0-branch.test.build.3.777"
_  | 789  | "ci"  | _  | "test/build000000.000003"  | "1.1.0-branch.test.build.0.3.789"
_  | 3    | "ci"  | _  | "test/build.000000.000003" | "1.1.0-branch.test.build.0.3.3"
_  | 3    | "ci"  | _  | "release/1.00.x"           | "1.0.1-branch.release.1.0.x.3"
```

Changes
=======

![FIX] Snapshot branchname strategy

311 of 401 relevant lines covered (77.56%)

2.22 hits per line

Jobs
ID Job ID Ran Files Coverage
1 12.1 0
77.56
2 12.2 0
77.56
3 12.3 0
77.56
4 12.4 0
75.83
Source Files on build 12
Detailed source file information is not available for this build.