strongloop / loopback-next / 18760

76%

push

travis-ci-com

fix(repository): fix DynamicModelCtor type to correctly preserve Props

Before this change, the following code would create an instance
with the type of the base model class, ignoring custom model properties:

```ts
const Product = defineModelClass<typeof Model, {name: string}>(
  Model,
  definition,
);
const p = new Product();
// p has type Model now
```

This patch fixes the problem by changing the order in which constructor
functions are defined in `DynamicModelCtor`, so that the compiler always
picks the constructor returning `Base & Props`.

Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com>

5538 of 6607 branches covered (83.82%)

Branch coverage included in aggregate %.

14959 of 15813 relevant lines covered (94.6%)

1101.52 hits per line