gnosis / dex-js / 649

77%

develop: 100%

push

travis-ci

Format Smart (#149)

* Function: formatSmart

* tests

* lock

* Tests: renamed file + fixed tests

* Constants: added some, moved some

1. added BN constants used in smart

* Format: changed core formatSmart logic

1. removed Intl library dependency
2. optimised as much as possible ;)

* Fixed constant names (consistency) + comment

* test comments

* fraction => decimals & pass constants in

* Many PR review fixes

1. pass constants directly into fns when necessary
2. remove unused params
3. remove unsused options
4. change some if/else statements to use single if, when necessary
5. explicit .toString(10)

* handle division math with BigNumber

1. dont use BN and precision math

* change DEFAULT_SMALL_LIMIT to string

1. let fn handle conversion to BigNumber

* if ZERO return '0'

Co-authored-by: Leandro Boscariol <alfetopito@users.noreply.github.com>

* PR fix concerning decimal/integer format

Co-authored-by: Leandro Boscariol <alfetopito@users.noreply.github.com>

116 of 167 branches covered (69.46%)

Branch coverage included in aggregate %.

258 of 330 relevant lines covered (78.18%)

12.72 hits per line