cn / GB2260.py / 41

100%

push

travis-ci

fix cache KeyError when garbage collected

WeakValueDictionary cache may get garbage collected, so the test "if key in cache" is not safe.
Let's test it on the fly.

Here is the exception happened to me:

  File "algo.py", line 64, in search
    if check_identity(id):
  File "algo.py", line 30, in check_identity
    division = gb2260.get(region)
  File "/opt/pypy3/site-packages/gb2260/division.py", line 59, in get
    return cache[key]
  File "/opt/pypy3/lib-python/3/weakref.py", line 159, in __getitem__
    raise KeyError(key)
KeyError: 621121

3 of 3 new or added lines in 1 file covered. (100.0%)

90 of 90 relevant lines covered (100.0%)

7.0 hits per line