ladybug-tools / honeybee-radiance / 329

81%

push

travis-ci

fix(model): Update Model.to.rad_folder to work with recent edits

This commit brings honeybee-radiance in line with the recent refactor of honeybee-radiance folder.

I don't expect the edits to result in any significant performance improvements since roughly the same number of checks are still performed (there may be a small improvement form just writing fewer files, albeit with the same overall file contents).

However, the changes greatly simplified the code. Previously, the Model.to.rad_folder method was over 200 lines long, which was realistically as short as it could be given that there were 16 folders that had to be written to.

For the static files (where much of the new simplification occurred), I mostly stuck to writing three files into the folders (.rad, .mat, and .blk). However, I separated the scene in two: 3 envelope files (containing honeybee Faces) and 3 shade files (containing honeybee Shades). I did this since the to.rad_folder code was simpler this way and there may be some cases where this separation is useful to people looking over the file contents.

66 of 66 new or added lines in 2 files covered. (100.0%)

4458 of 5450 relevant lines covered (81.8%)

1.64 hits per line