186
29%

Ran 16 May 2020 11:07PM UTC

Jobs 1

Files 26

Run time 2s

Badge

Embed ▾

Committed 16 May 2020 11:01PM UTC coverage: 7.645% (+0.003%) from 7.642%

Build # 186

Build Type

push

travis-ci-com

Committed by

web-flow

Commit Message

Provides more flexibility for customizations (#91)

* Provides flexibility to customize reconcile logic

1. Move ReconcileJobs, ReconcilePods, ReconcileServices to interface. JobController provides common implementation. User doesn’t necessarily implement these methods a
nd only user facing change is user need to embed JobController. If operators has custom logic, they can override these reconciling logic

2. Expose few private methods and when user want to have some customization, they can reuse those method
- DeletePodsAndServices
- PastBackoffLimit
- PastActiveDeadline
- CleanupJob

* Expose methods for kubebuilder based operator

1. JobController has default implementation for GetPodsForJob and GetServicesForJob. User needs to pass a PodLister and SeviceLister. For operators using informers, user don’t need to make any change.

2. However, the challenge part if we have more operators are built with kubebuilder which use higher level APIs and doesn’t create `SharedInformerFactory`. In order to accomendate these cases, we expose methods and user can implement them using latest  reconciler.Client.List().

Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com>

Run Details

162 of 2119 relevant lines covered (7.65%)

0.33 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	186.1	16 May 2020 11:07PM UTC	0	7.65	Travis Job 186.1

Source Files on build 186

Detailed source file information is not available for this build.

kubeflow / common / 186
29%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 186

kubeflow / common / 186 29%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 186

kubeflow / common / 186
29%

README BADGES
x