spesmilo / electrum / 10169
63%

DEFAULT BRANCH: master
Ran
Jobs 3
Files 60
Run time 39s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
10169

push

travis-ci

SomberNight 
commands: make 'wallet'-mangling in decorator less obscure, and fixes

- some commands expect a 'wallet_path' arg, while others expect 'wallet'
- 'wallet_path' in the end is supposed to be a str,
  'wallet' in the end is supposed to be an Optional[Abstract_Wallet]
- initially, in the decorator, 'wallet' can be a str, in which case
  the decorator replaces it with an Abstract_Wallet (from the daemon)
- Previously the decorator sometimes converted 'wallet_path' to 'wallet'.
  This was because when called from the CLI it was always given 'wallet_path' (and never 'wallet),
  while when called from JSON-RPC it was given either 'wallet' or 'wallet_path' (depending on command).
  Now, the CLI also behaves as JSON-RPC, and hence 'wallet_path' and 'wallet' are fully separate.
- A bug is fixed where, when a command that only optionally takes a 'wallet' (such as gettransaction),
  was called from the JSON-RPC with the arg present, it raised; and when called from CLI with the arg present
  the arg was not actually passed to the command.
- A bug is fixed where if one command calls another command (that both take a 'wallet'),
  it would raise (due to assuming 'wallet' is str and needs to be converted to Abstract_Wallet).
  This fixes #6154.

-----

$ ./run_electrum --testnet daemon -d
$ ./run_electrum --testnet load_wallet -w ~/.electrum/testnet/wallets/default_wallet

$ curl --data-binary '{"id":"curltext","jsonrpc":"2.0","method":"gettransaction","params":{"txid":"9f43ff71e1af76325c854d9aa199550ce"}}' http://user:pass@127.0.0.1:7777
{"jsonrpc": "2.0", "result": "02000000031ce1dcfb00fdfe0003f081a342edd0c3022eafb71b0c45022100dda2b86e797e7c21d94ac4884e9ff27339ea... (continued)

13284 of 22773 relevant lines covered (58.33%)

1.75 hits per line

Jobs
ID Job ID Ran Files Coverage
1 10169.1 0
58.27
 Travis Job 10169.1
2 10169.2 0
58.25
 Travis Job 10169.2
3 10169.3 0
58.49
 Travis Job 10169.3
Source Files on build 10169
Detailed source file information is not available for this build.