20874
89%
master: 93%

Ran 14 May 2020 07:41AM UTC

Jobs 1

Files 386

Run time 30s

Badge

Embed ▾

pending completion

Build # 20874

Build Type

push

travis-ci

Committed by

SpacePossum

Commit Message

bug #4934 YodaStyleFixer - fix for conditions weird are (kubawerlos)

This PR was squashed before being merged into the 2.15 branch (closes #4934).

Discussion
----------

YodaStyleFixer - fix for conditions weird are

While on the [other](https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/4929) fix working I was, it thinking me made what the reason is for these conditions:
```php
            if ($token->isComment() || $token->isWhitespace()) {
                if ($expectNothing) {
                    return false;
                }

                continue;
            }
```
Why do the check we want for `$expectNothing` only for comments and whitespaces, expect the opposite I would. So these 2 test case added I have and what weird is only 1 failed has: https://travis-ci.org/github/FriendsOfPHP/PHP-CS-Fixer/jobs/678270023

The fix to not nest them is, @bgotink, @keradus and @SpacePossum I ping (as they the authors are) to review.

May the force be with you.

Commits
-------

60dc742b YodaStyleFixer - fix for conditions weird are

Run Details

13355 of 16278 relevant lines covered (82.04%)

35.04 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
7	20874.7 (DEFAULT_COMPOSER_FLAGS="--optimize-autoloader --no-interaction --no-progress" COMPOSER_FLAGS="")	14 May 2020 07:40AM UTC	0	82.04	Travis Job 20874.7

Source Files on build 20874

Detailed source file information is not available for this build.

FriendsOfPHP / PHP-CS-Fixer / 20874
89%
master: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 20874

FriendsOfPHP / PHP-CS-Fixer / 20874 89% master: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 20874

FriendsOfPHP / PHP-CS-Fixer / 20874
89%
master: 93%

README BADGES
x