strongloop / loopback-next / 18243

76%

push

travis-ci-com

chore: fix code that leads to TS2783: 'id' is specified more than once

TypeScript 3.9.x reports an error for
`expect(toJSON(created)).to.deepEqual({id: response.body.id, ...expected});`
with the following reasoning:

1. The inferred type of `expected` has an `id` (non-optional) property.
2. The spread assignment has overriding property `id` from the 1st and 2nd
   argument.
3. The TS compiler think the 1st `id` will be ALWAYS overridden and
   it is probably a bug in the code.
4. In our case, `expected.id` is not defined when it's instantiated from
   `Todo` class without `create`. Please note the `Todo.prototype.id` is
   NOT marked as optional.

5394 of 6349 branches covered (84.96%)

Branch coverage included in aggregate %.

14673 of 15442 relevant lines covered (95.02%)

1103.72 hits per line