FAForever / server / 3638
96%

DEFAULT BRANCH: develop
Ran
Jobs 1
Files 59
Run time 7s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
3638

push

travis-ci

web-flow 
Rating Service (#553)

* Add an empty rating service

* Functionality for compute_rating and persisting results moved to RatingService.

* Faf-stack to version v20.4.18

* All rating functionality moved to RatingService

* Adapt tests, formatting.

* Add RatingService unit tests.

* RatingService employs an asynchronous worker to rate games in the order enqueued.

* Add metrics for ratin_service queue length.

Quick typo cleanup

Adapt tests after rebase

* Review comments.

* Persist Rating errors

If the game_rater throws an error, the game_stats.validity column is updated with ValidityState.UNKNOWN_RESULT

* Fetch ratings from new tables

PlayerService and RatingService fetch ratings from new leaderboard_rating table first and fall back to old rating tables if no entry exists.

* RatingService creates leaderboard_rating entries on load

* Save to new rating tables

* Overwrite before_mean in game_player_stats at rating time.

* Quick fixes after rebase.

* Adding RatingService to ServiceMeta.

* Refactor game.rate_game

Common functionality moved to base class.

* Introduce GameResolver

Outcame decision logic moved from GameRater to GameResolver, evaluated before queueing up for rating.

* Tidying up.

* Create new rating entry if none found.

* Run flake8 on tests.

* Test coverage for argument checks.

* Minor review comments.

* SQLAlchemy for rating service inserts

* SQLAlchemy for game inserts

* SQLAlchemy for update statements in rating service.

* Fetch new rating tables in a single query

* Improve game_player_stats update queries.

* SQLAlchemy for UPDATEs in game.py.

* Move external imports to __all__.

* Merge _update_rating_tables into _persist_rating_changes.

* Query legacy won_games

* Remove separate query for game_player_stats id.

* Single query for fetching legacy ratings.

* Remove mapId 0 from test-data.sql

* Review comments

* Revert count... (continued)

3771 of 3920 relevant lines covered (96.2%)

0.96 hits per line

Jobs
ID Job ID Ran Files Coverage
1 3638.1 0
96.2
 Travis Job 3638.1
Source Files on build 3638
Detailed source file information is not available for this build.