gap-system / gap / 11888

4%

Build Type

push

travis-ci

Committed by fingolfin

Commit Message

kernel: introduce GAP_TRY/GAP_CATCH helper macros

These are meant to replace uses of TRY_IF_NO_ERROR/CATCH_ERROR outside
of read.c, as those macros really were meant for code in the GAP
scanner/reader; for other code, they are dangerous to use because of the
way they interact with `STATE(NrError)`.

The new macros have the added benefit that they automatically save
and restore the value of `STATE(ReadJmpError)`, so it is safe to use
them recursively.

For now we only switch to GAP_TRY/GAP_CATCH in places were it is clear
that doing so is safe (as in: not touch `STATE(NrError)` is OK). To be
explicit, here are arguments why each change ought to be safe:

- gap.c, reading lib/init.g: if this catches, then we call `Panic`, so
  the value `STATE(NrError)` is irrelevant
- `FuncSERIALIZE_TO_NATIVE_STRING`: did not change `STATE(NrError)`
- `FuncDESERIALIZE_NATIVE_STRING`: did not change `STATE(NrError)`
- `ThreadedInterpreter`: this is the outermost handler for a thread;
  once we catch an error here, we exit this function, which then leads
  to the termination of the thread (for that reason, we also get rid of
  the `ClearError` and `SWITCH_TO_OLD_LVARS` at the end -- they are
  pointless
- `FuncWITH_TARGET_REGION`: did not change `STATE(NrError)`
- `Call0ArgsInNewReader`, `Call1ArgsInNewReader`: these save & restore
  the value of `STATE(NrError)` anyway

Run Details

23 of 28 new or added lines in 5 files covered. (82.14%)

6 existing lines in 3 files now uncovered.

278934 of 330601 relevant lines covered (84.37%)

31767178.76 hits per line