986
38%

Ran 27 Apr 2020 12:38PM UTC

Jobs 1

Files 153

Run time 20s

Badge

Embed ▾

pending completion

Build # 986

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Fix type mismatch when checking :by_user URL parameter (#115)

params[:by_user] is usually a string, which will never compare equal
to current_user.id (an integer).

The main effect is that non-staff users weren't authorized to view
/submissions/by_user/:user_id/by_problem/:problem_id even when
:user_id was their own ID. Also, some of the UI messages were wrong
(e.g. "No submissions found" instead of "You have no submissions").

Use params[:by_user].to_i when comparing to current_user.id.

(Note: `params[:by_user] == current_user.id.to_s` almost works but can
produce incorrect results if params[:by_user] has leading zeros.)

Also, store a string in params[:by_user] when the route is
/submissions/my for consistency.

Run Details

2325 of 7016 relevant lines covered (33.14%)

4.81 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	986.1 (2.3.8)	27 Apr 2020 12:38PM UTC	0	33.14	Travis Job 986.1

Source Files on build 986

Detailed source file information is not available for this build.

NZOI / nztrain / 986
38%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 986

NZOI / nztrain / 986 38%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 986

NZOI / nztrain / 986
38%

README BADGES
x