jshint / jshint / 3063

100%

push

travis-ci

[[CHORE]] Remove unreachable branch (#3467)

The `_checkParams` function included a guard to ensure it was only
invoked in appropriate situations. Because its one and only call site
was itself guarded by an equivalent condition, the branch in
`_checkParams` was unreachable.

Although this situation made the internal guard of `_checkParams` safe
to remove, doing so would have made the function more dangerous in
general since anyone introducing new invocations in the future would
have to take care to perform a similar check.

To avoid introducing such a dangerous interface, remove the function
entirely and inline its body at its only call site.

6 of 6 new or added lines in 1 file covered. (100.0%)

4492 of 4492 relevant lines covered (100.0%)

34670.67 hits per line