hgrecco / pint / 1736

92%

master: 91%

push

travis-ci

Merge #1087

1087: Implement prod r=hgrecco a=keewis

This implements `numpy.prod`. Support for passing both `axis` and `where` is not quite there, yet, because I couldn't figure out how to broadcast `where` to match the shape of the input array:
```python
if axis is not None and where is not None:
    # broadcast where to match the shape of a:
    # ↓ this is not reliable and does not work well if a contains a dask.array
    where_ = np.broadcast_to(where, a.shape)

    exponents = np.sum(where_, axis=axis)
    exponent = np.max(exponents)
    if not all((exponents == exponent) | (exponents == 0)):
        # try to convert to dimensionless
        ...

result = np.prod(a._magnitude, *args, **kwargs)

if axis is not None and where is not None:
    units = a._units ** exponent
elif axis is not None:
    ...
else:
    ...
```

cc @jthielen

- [x] Closes #867
- [x] Executed ``black -t py36 . && isort -rc . && flake8`` with no errors
- [x] The change is fully covered by automated unit tests
- [ ] Documented in docs/ as appropriate
- [ ] Added an entry to the CHANGES file


Co-authored-by: Keewis <keewis@posteo.de>

15 of 15 new or added lines in 1 file covered. (100.0%)

3604 of 4007 relevant lines covered (89.94%)

11.84 hits per line