cucumber / cucumber-jvm / 3986

86%

master: 86%

push

travis-ci

[Core] Remove `cucumber.options` property (#1958)

`cucumber.options` was used to control cucumbers execution when run through `mvn test`. This is no longer required with the introduction of property based runtime options in #1741. Removing `cucumber.options` allows CLI argument parsing to be separated from property parsing which simplifies the complexity of parsing significantly.

Additionally
 - We remove `--add-plugin` and associated logic in `RuntimeOptionsBuilder`. All plugins are added by default.
 - Separate calling `System.exit` from parsing the runtime options. Main should check if exit is required after parsing.
 - Write tests that validate if the correct text is written to `System.out` and `System.err` by injecting these into `CommandlineOptionsParser`.

Fixes: https://github.com/cucumber/cucumber-jvm/issues/1779

167 of 167 new or added lines in 6 files covered. (100.0%)

6660 of 7692 relevant lines covered (86.58%)

0.87 hits per line