4096
83%

Ran 23 Apr 2020 11:46AM UTC

Jobs 12

Files 133

Run time 21min

Badge

Embed ▾

pending completion

Build # 4096

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Map exceptions to error responses in all rest endpoints (#396)

* Create base classes for jax-rs and spring-web resource to provice common exception mappings

* use handleExceptions in all jax-rs endpoints

* use nflow eclipse formatter settings in nflow-rest-api-jax-rs

* use nflow formatter settings in nflow-rest-api-spring-web

* use handleExceptions in all spring-web endpoints

* wrap EmptyResultDataAccessException to NflowNotFoundException in workflow service to provide better exception message for mapping

* add tests for handleExceptions

* return 404 not found instead of 409 conflict when updated workflow instance is not found

* test different exception mappings in ResourceBaseTest

Co-authored-by: Edvard Fonsell <edvard.fonsell@nitorcreations.com>

Run Details

97 of 97 new or added lines in 15 files covered. (100.0%)

2797 of 3424 relevant lines covered (81.69%)

9.8 hits per line

New Missed Lines in Diff

Lines	Coverage	File
2	100.0	nflow-engine/src/main/java/io/nflow/engine/service/NflowNotFoundException.java
2	100.0	nflow-rest-api-spring-web/src/main/java/io/nflow/rest/v1/springweb/WorkflowDefinitionResource.java
2	100.0	nflow-rest-api-spring-web/src/main/java/io/nflow/rest/v1/springweb/WorkflowExecutorResource.java
4	100.0	nflow-engine/src/main/java/io/nflow/engine/service/WorkflowInstanceService.java
4	100.0	nflow-rest-api-spring-web/src/main/java/io/nflow/rest/v1/springweb/StatisticsResource.java
5	100.0	nflow-rest-api-jax-rs/src/main/java/io/nflow/rest/v1/jaxrs/WorkflowInstanceResource.java
5	100.0	nflow-rest-api-spring-web/src/main/java/io/nflow/rest/v1/springweb/MaintenanceResource.java
17	100.0	nflow-rest-api-spring-web/src/main/java/io/nflow/rest/v1/springweb/WorkflowInstanceResource.java

Jobs

ID	Job ID	Ran	Coverage
1	4096.1 (DB=h2)	23 Apr 2020 11:46AM UTC	81.7	Travis Job 4096.1
2	4096.2 (DB=postgresql)	23 Apr 2020 11:46AM UTC	81.7	Travis Job 4096.2
3	4096.3 (DB=mysql)	23 Apr 2020 11:46AM UTC	81.7	Travis Job 4096.3
4	4096.4 (DB=mariadb)	23 Apr 2020 11:46AM UTC	81.7	Travis Job 4096.4
5	4096.5 (DB=sqlserver)	23 Apr 2020 11:47AM UTC	81.7	Travis Job 4096.5
6	4096.6 (DB=db2)	23 Apr 2020 12:00PM UTC	81.7	Travis Job 4096.6
7	4096.7 (DB=h2)	23 Apr 2020 11:55AM UTC	81.69	Travis Job 4096.7
8	4096.8 (DB=postgresql)	23 Apr 2020 11:55AM UTC	81.69	Travis Job 4096.8
9	4096.9 (DB=mysql)	23 Apr 2020 11:55AM UTC	81.69	Travis Job 4096.9
10	4096.10 (DB=mariadb)	23 Apr 2020 11:56AM UTC	81.69	Travis Job 4096.10
11	4096.11 (DB=sqlserver)	23 Apr 2020 12:04PM UTC	81.69	Travis Job 4096.11
12	4096.12 (DB=db2)	23 Apr 2020 12:08PM UTC	81.69	Travis Job 4096.12

NitorCreations / nflow / 4096
83%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Jobs

Source Files on build 4096

NitorCreations / nflow / 4096 83%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Jobs

Source Files on build 4096

NitorCreations / nflow / 4096
83%

README BADGES
x