pynamodb / PynamoDB / 2833

95%

devel: 95%

push

travis-ci

<a href="https://github.com/pynamodb/PynamoDB/commit/<a class=hub.com/pynamodb/PynamoDB/commit/<a class="double-link" href="https://git"><a class=hub.com/pynamodb/PynamoDB/commit/<a class="double-link" href="https://git"><a class=hub.com/pynamodb/PynamoDB/commit/<a class="double-link" href="https://git"><a class=hub.com/pynamodb/PynamoDB/commit/63b01ecf8987ed98e92d78c6abb8c94520ad6236">63b01ecf8<a href="https://github.com/pynamodb/PynamoDB/commit/63b01ecf8987ed98e92d78c6abb8c94520ad6236">&quot;&gt;&amp;lt;a href=&amp;quot;https://github.com/pynamodb/PynamoDB/commit/&lt;/a&gt;&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/pynamodb/PynamoDB/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=&lt;/a&gt;hub.com/pynamodb/PynamoDB/commit/63b01ecf8987ed98e92d78c6abb8c94520ad6236&quot;&gt;63b01ecf8&lt;/a&gt;&lt;a href=&quot;https://github.com/pynamodb/PynamoDB/commit/63b01ecf8987ed98e92d78c6abb8c94520ad6236&quot;&gt;&amp;lt;a href=&amp;quot;https://github.com/pynamodb/PynamoDB/commit/63b01ecf8987ed98e92d78c6abb8c94520ad6236&amp;quot;&amp;gt;&amp;amp;quot;&amp;amp;gt;Make (GS,LS)Index an indexable type in </a>runtime (#769)

Following &lt;/a&gt;&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/pynamodb/PynamoDB/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/pynamodb/PynamoDB/commit/<a class="double-link" href="https://github.com/pynamodb/PynamoDB/commit/5426ed9081e91316b214d6c10b447cfa1da8b0af">5426ed908</a>&quot;&gt;5426ed908&lt;/a&gt;&quot;&gt;5426ed908&lt;/a&gt;&lt;a href=&quot;https://github.com/pynamodb/PynamoDB/commit/63b01ecf8987ed98e92d78c6abb8c94520ad6236&quot;&gt;, users found themselves having to write some rather unergonomic code to reconcile Python&amp;#39;s and a type-checker&amp;#39;s perspectives:

    if TYPE_CHECKING:
        _MyModelGSI = GlobalSecondaryIndex[&amp;quot;MyModel&amp;quot;]
    else:
        _MyModelGSI = GlobalSecondaryIndex

    class MyModelUserIdGSI(_MyModelGSI):
        &amp;quot;&amp;quot;&amp;quot;A GSI for looking up by user ID.&amp;quot;&amp;quot;&amp;quot;
       ...

    class MyModelEmailGSI(_MyModelGSI):
        &amp;quot;&amp;quot;&amp;quot;A GSI for looking up by email.&amp;quot;&amp;quot;&amp;quot;
       ...

This addresses it by allowing users to rewrite this as:

    class MyModelUserIdGSI(GlobalSecondaryIndex[&amp;quot;MyModel&amp;quot;]):
        &amp;quot;&amp;quot;&amp;quot;A GSI for looking up by user ID.&quot;&quot;&quot;
       ...

    class MyModelEmailGSI(G... (continued)

2578 of 2704 relevant lines covered (95.34%)

4.75 hits per line