• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

jlfwong / speedscope / 683
47%

Build:
DEFAULT BRANCH: master
Ran 20 Apr 2020 03:28PM UTC
Jobs 4
Files 64
Run time 46s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
683

push

travis-ci

web-flow
Fix the build for node 13.x, make travis test 10, 12, 13, stable (#263)

@JustinBeckwith pointed out in #262 that `npm install` was broken in node 13.x, and @DanielRuf pointed in #254 that test fail for node 11+ because of a change to stability of sorting.

This PR seeks to address both of those.

The installation issue was fixed by just regenerating `package-lock.json` without needing to bump any of the direct dependency versions. The test failure issue requires manual intervention.

To fix the sort stability issue, I updated the tests to use the stable sort values (these were all the correct values, though some of the test values were incorrect).

To make the suite still pass for node 10, I added a hack where I override `Array.prototype.sort` with a stable implementation that's *only* used in tests (See comments in code for a justification for why)

## Test Plan

Before this PR: `npm install` on node 13.x fails & `npm run jest` results in test failures
After this PR: `npm install` on node 13.x passes & `npm run jest` passes for node 10, 12, and 13.

872 of 1993 branches covered (43.75%)

Branch coverage included in aggregate %.

2208 of 4571 relevant lines covered (48.3%)

26960.63 hits per line

Jobs
ID Job ID Ran Files Coverage
1 683.1 20 Apr 2020 03:28PM UTC 0
46.91
Travis Job 683.1
2 683.2 20 Apr 2020 03:28PM UTC 0
46.88
Travis Job 683.2
3 683.3 20 Apr 2020 03:28PM UTC 0
46.88
Travis Job 683.3
4 683.4 20 Apr 2020 03:28PM UTC 0
46.86
Travis Job 683.4
Source Files on build 683
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #683
  • d30bb2ef on github
  • Prev Build on master (#672)
  • Next Build on master (#685)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc