141
29%

Ran 20 Apr 2020 01:58AM UTC

Jobs 1

Files 24

Run time 2s

Badge

Embed ▾

Committed 20 Apr 2020 01:53AM UTC coverage: 8.235% (-0.9%) from 9.135%

Build # 141

Build Type

push

travis-ci-com

Committed by

web-flow

Commit Message

Add PodControlInterface and PodControllerRefManager (#73)

* Add PodControlInterface and FakePodControl

* Add comments for service event reasons

* Skip deleting pods/services already in termination

Kubernetes pkg/controller/controller_utils.go doesn’t have this logic. This is from kubeflow/tf-operator/pull/998. I think it’s safe to keep the logic here.

* Remove Kubernetes controller dependency

Use `KeyFunc` instead of k8s.io/kubernetes/pkg/controller.KeyFunc

* Add Base and PodControllerRefManager

Current implementation use PodControllerRefManager from `k8s.io/kubernetes/pkg/controller` and self-implemented `ServiceControllerRefManager` which brings some problems.

1. Pod impl may change along with k8s upgrade, service impl doesn’t
2. It’s not helping us remove Kubernetes direct dependency.
3. It’s not that straighforward for maintainers and contributors.

This change make sure we folk everything we need and remove ref_manager dependency.

* Rename service_ref_manager to controller_ref_manager

Since this file contains both BaseControllerRefManager, PodControllerRefManager and ServiceControllerRefManager. It makes sense to rename it to controller_ref_manager.go

* Address code review feedbacks

Run Details

168 of 2040 relevant lines covered (8.24%)

0.35 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	141.1	20 Apr 2020 01:58AM UTC	0	8.24	Travis Job 141.1

Source Files on build 141

Detailed source file information is not available for this build.

kubeflow / common / 141
29%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 141

kubeflow / common / 141 29%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 141

kubeflow / common / 141
29%

README BADGES
x