quantopian / zipline / 3625

87%

master: 88%

Build Type

push

travis-ci

Committed by Eddie Hebert

Commit Message

MAINT: Move possible side assignment to insert metadata method.

The previous workflow was:

- insert basic metadata for all assets

- iterate over all metadata entries. Create a sid if one does not
exist

- call insert_metadata again to update the assigned sid value.

Instead, create a sid, if missing on the initial metadata assignment and
remove the second pass of calling insert_metadata.

Also, since the sid assignment code is only done in this one context,
inline the sid assignment code so that there is less code step through
while looking for where sid assignment is done.

Run Details

8 of 8 new or added lines in 1 file covered. (100.0%)

5876 of 6719 relevant lines covered (87.45%)

1.75 hits per line