370
82%

Ran 11 Apr 2020 09:18AM UTC

Jobs 1

Files 6

Run time 1s

Badge

Embed ▾

pending completion

Build # 370

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Fix handling of managed dependencies edge cases (#49)

The existing logic for filtering the dependency hierarchy misses some
edge cases, including the case where a dependency is declared without a
version (e.g. `:dependencies [[foo]]`) and the corresponding managed
dependency is declared in another `project.clj` file (as can be the case
when using plugins like lein-parent).

This change addresses these edge cases by delegating dependency
resolution to Leiningen.

Based on the commit history it appears that `leiningen.nvd.deps` was
was added to filter the classpath to only include dependencies declared
in a `:dependencies` or `:managed-dependencies` list. In particular,
there was a desire to exclude `:plugins` from the scanned classpath.
Based on #1 I believe there was also a desire to exclude certain base
profiles (presumably `:user` and `:base`).

Current versions of Leiningen do not appear to include `:plugins` in
`get-classpath` computation, but do include some other directories which
are irrelevant in this case (e.g. the local src and resource
directories). Rather than reverting back to using `get-classpath` this
change uses `resolve-managed-dependencies` to exclude these extraneous
classpath elements. The `:base`, `:system` and `:user` profiles are also
unmerged so that only dependencies of the project itself are included.

Run Details

197 of 209 relevant lines covered (94.26%)

4.75 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	370.1	11 Apr 2020 09:18AM UTC	0	94.26	Travis Job 370.1

Source Files on build 370

Detailed source file information is not available for this build.

rm-hull / lein-nvd / 370
82%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 370

rm-hull / lein-nvd / 370 82%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 370

rm-hull / lein-nvd / 370
82%

README BADGES
x