great-expectations / great_expectations / 5149

0%

push

travis-ci

Fix compatibility with MS SQL Server. (#1269)

* Fix compatibility with MS SQL Server.

Following fixes are implemented:
* Temporary table names are now prefixed with '#' as required by MS SQL dialect
* Temporary table names only persist within a connection so engine is overridden with a connection (the same happens for SQLite)
* Create temporary table using "select .. into {table_name} from ..
* head() now uses "top" instead of "limit" for MS SQL
* get_column_quantiles(): add an empty over() clause as required for MS SQL
* get_column_stdev(): use "stdevp" function for MS SQL instead of "stddev_samp"

Open issues:
* get_table_columns(): returns an empty list because table introspection yields an empty column list
* get_column_count(): returns 0 (because get_table_columns() is empty)
* expect_column_values_to_be_of_type(): doesn't work because get_table_columns() returns an empty list
* expect_column_values_to_be_in_type_list(): idem

* Fix spaces around parameter equals.

* Add maxsplit = 1 argument.

* Fix unnecessary space between arguments.

* Fix column reflection

* Lowercase before split on 'from' in custom_sql

* Detect case in custom_sql instead of transforming it to lowercase!

* Fetch column types as well!

Co-authored-by: Pieter Jan Kerstens <pieterjan@tropos.io>
Co-authored-by: Taylor Miller <Aylr@users.noreply.github.com>

26 of 26 new or added lines in 1 file covered. (100.0%)

9605 of 12394 relevant lines covered (77.5%)

2.32 hits per line