• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

uber / nebula.gl / 1855
22%

Build:
DEFAULT BRANCH: master
Ran 09 Apr 2020 09:44PM UTC
Jobs 1
Files 118
Run time 10s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
1855

push

travis-ci-com

web-flow
Typescript migration (#377)

I created a new PR to take advantage of conversion tooling.
## Strategy
* use Flow to typescript CLI https://github.com/khan/flow-to-ts to automate most of the conversion
* Use of [Typescript ESLINT](https://github.com/typescript-eslint/typescript-eslint) to quickly fix types issues.
* Convert the code to typescript with minimal/no  refactor.
* use Loose typescript rules to allow progressive transition
    * I disabled `typescript strict mode`
   * Use `//@ts-ignore`  to mask types errors
   * Use `any` for unknown types

**This PR does not bring the code to the typescript standard.  My idea was to convert first to typescript and from there, we all can improve the types.**

While converting, a lot of errors, missing imports and export surfaced. I fixed the best I could.

## What is next?
The following tasks can be done to improve code quality
- Converting examples to typescript or remove types from examples.
- Move to a stricter typescript and ESLINT rules
- Replace `geojson-types.ts` by [@types/geojson](https://www.npmjs.com/package/@types/geojson)
## Note
If this PR is merged, please take 10 min to get familiar with [Typescript](https://www.typescriptlang.org)

To create a file that has `jsx` please use `.tsx` extension. For anything else use `.ts`.
I upgraded to prettier 2.0 which seems to now have trailing commas by default.

489 of 2398 branches covered (20.39%)

Branch coverage included in aggregate %.

588 of 588 new or added lines in 97 files covered. (100.0%)

1168 of 4974 relevant lines covered (23.48%)

1.32 hits per line

Jobs
ID Job ID Ran Files Coverage
1 1855.1 09 Apr 2020 09:44PM UTC 0
22.48
Travis Job 1855.1
Source Files on build 1855
Detailed source file information is not available for this build.
  • Back to Repo
  • Build #1855
  • c47538b2 on github
  • Prev Build on master (#1827)
  • Next Build on master (#1856)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc