Ocramius / GeneratedHydrator / 115

30%

Build Type

Pull #37

travis-ci

Committed by Matthias Noback

Commit Message

Allow generated classes target dir to be null

Because of the string casting, in my code I have to call `setGeneratedClassesTargetDir()` like this:

```php
class HydrateUsingGeneratedHydrator implements Hydrate
{
    /**
     * @var string|null
     */
    private $cacheDir;

    public function __construct($cacheDir)
    {
        $this->cacheDir = $cacheDir;
    }

    public function hydrate(array $data, $object)
    {
        $configuration = new Configuration(get_class($object));

        if ($this->cacheDir !== null) {
            $configuration->setGeneratedClassesTargetDir($this->cacheDir);
        }
        ...
}
```

The proposed change allows me to just call `$configuration->setGeneratedClassesTargetDir($this->cacheDir);` without the extra `if` clause.

Pull Request Pull Request #37:

Run Details

2 of 2 new or added lines in 1 file covered. (100.0%)

170 of 175 relevant lines covered (97.14%)

5.37 hits per line